TST: GH30999 Add match=msg to all but two pytest.raises in tests/io #38724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except test_sql, which has two I can't test on this machine
jreback
requested changes
Dec 27, 2020
| if quoting == csv.QUOTE_NONE: | ||
| # We expect no match, so there should be an assertion | ||
| # error out of the inner context manager. | ||
| with pytest.raises(AssertionError): |
There was a problem hiding this comment.
thanks, this was some really old testing code
| @@ -223,11 +221,12 @@ def test_s3_parquet(s3_resource, s3so): | |||
| tm.assert_equal(df1, df2) | |||
|
|
|||
|
|
|||
| @td.skip_if_installed("fsspec") | |||
There was a problem hiding this comment.
@jreback fixed this, merged master, green except for Travis CI
jreback
added
Error Reporting
yep your changes are fine. general restructuring of tests should be a dedicated PR, but moderinzation like this is ok. |
jreback
approved these changes
Dec 28, 2020
|
thanks @moink |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request partially addresses xref #30999 to remove bare
pytest.raisesby addingmatch=msg. It doesn't close that issue as I have only addressed test modules in the pandas/tests/io/ directory.I thought this was going to be relatively small because there were only 25 such instances, but it turned out some of them were in methods that were reused several times, so this ended up larger than I expected.
There were a couple of cases where I found the structure of the tests quite confusing, with an internal function definition and two nested asserts. This structure also made it difficult to add the assertion about the error message. I restructured the tests to be, in my opinion, more straightforward.
There's one file, pandas/tests/io/test_sql.py, with two instances of
pytest.raisesin tests which were skipped on my machine and which I couldn't figure out how to run, so those are left as is.black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff