Skip to content

BLD: add setup_requires in setup.py so pandas can be used with buildout #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2013

Conversation

ejnens
Copy link
Contributor

@ejnens ejnens commented Jun 14, 2013

Numpy is a setup-time dependency due to some .h files, but is not declared as such. This causes tools like buildout ( http://buildout.org/ ) to fail.

Adding the setup_requires kwarg to the setuptools config shoud fix this: buildout will correctly assemble any declared setup-time dependencies, before executing the pandas build.

closes #3861

Numpy is a setup-time dependency due to some .h files, but is not declared as such. This causes tools like buildout to fail.
@jreback
Copy link
Contributor

jreback commented Jun 18, 2013

@wesm any problems with this?

@wesm
Copy link
Member

wesm commented Jun 18, 2013

👍

jreback added a commit that referenced this pull request Jun 18, 2013
BLD: add setup_requires in setup.py so numpy can be used with buildout
@jreback jreback merged commit 028c9ed into pandas-dev:master Jun 18, 2013
@jreback
Copy link
Contributor

jreback commented Jun 18, 2013

thanks @ejnens

@ghost
Copy link

ghost commented Jun 19, 2013

related statsmodels/statsmodels#588 / pydata/patsy#16, but 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup.py should define setup_requires=
3 participants