Skip to content

CLN: remove pd import in pandas/core/computation #39268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2021
Merged

CLN: remove pd import in pandas/core/computation #39268

merged 2 commits into from
Jan 19, 2021

Conversation

ivanovmg
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Remove import pandas as pd in pandas/core/computation.

MarcoGorelli
MarcoGorelli approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, once a few more are done we can add a quick check

@jbrockmendel jbrockmendel merged commit d512b31 into pandas-dev:master Jan 19, 2021
@jbrockmendel
Copy link
Member

Thanks @ivanovmg

@ivanovmg ivanovmg deleted the cleanup/pd branch January 20, 2021 03:31
nofarm3 pushed a commit to nofarm3/pandas that referenced this pull request Jan 21, 2021
@ivanovmg @nofarmish
CLN: remove pd import in pandas/core/computation (pandas-dev#39268)
be6c41c 
* CLN: avoid pd import in computation/expr.py

* CLN: avoid pd import in computation/pytables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovmg @jbrockmendel @MarcoGorelli