Skip to content

DOC: Clarify behavior for Series with dict-like data and index #39374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 7, 2021
Merged

DOC: Clarify behavior for Series with dict-like data and index #39374

merged 7 commits into from
Feb 7, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Jan 24, 2021

I think the previous description was wrong. We only reindex if the index is not None, not the opposite.

@phofl phofl added Docs Series Series data structure labels Jan 24, 2021
jreback
jreback reviewed Jan 25, 2021
View reviewed changes
@jreback jreback added this to the 1.3 milestone Feb 4, 2021
jreback
jreback requested changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add an Example that shows the usage in the OP (and say this in a comment what is happening)

@phofl
Copy link
Member Author

phofl commented Feb 4, 2021

Added the example.

I think we should backport here? The sentence I fixed was added in 1.2 and is wrong

@jreback jreback modified the milestones: 1.3, 1.2.2 Feb 5, 2021
@jreback
Copy link
Contributor

jreback commented Feb 5, 2021

Added the example.

I think we should backport here? The sentence I fixed was added in 1.2 and is wrong
yup can backport

@jreback jreback merged commit 965bfa1 into pandas-dev:master Feb 7, 2021
@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

thanks @phofl

@jreback
Copy link
Contributor

jreback commented Feb 7, 2021

@meeseeksdev backport 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 7, 2021
@phofl @meeseeksmachine
Backport PR pandas-dev#39374: DOC: Clarify behavior for Series with d…
687e616 
…ict-like data and index
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 7, 2021
Merged
simonjayhawkins pushed a commit that referenced this pull request Feb 7, 2021
@meeseeksmachine @phofl
Backport PR #39374: DOC: Clarify behavior for Series with dict-like d…
75f9bb8 
…ata and index (#39645)

Co-authored-by: patrick <[email protected]>
@phofl phofl deleted the 34534 branch February 7, 2021 21:58
CyberQin pushed a commit to CyberQin/pandas that referenced this pull request Feb 8, 2021
@phofl @CyberQin
DOC: Clarify behavior for Series with dict-like data and index (panda…
23a9b52 
…s-dev#39374)
@phofl phofl mentioned this pull request Feb 19, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Docs Series Series data structure
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

BUG: pd.Series produces NaN for valid input as per documentation
3 participants
@phofl @jreback @simonjayhawkins