Skip to content

REGR: Reading csv files with numbers with multiple leading zeros losses a lot of precision #39515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

REGR: Reading csv files with numbers with multiple leading zeros losses a lot of precision #39515

wants to merge 1 commit into from

Conversation

CalebBell
Copy link

Trying this change out to see what the tests say. It fixes the current issue I experienced.

@simonjayhawkins simonjayhawkins changed the title Fix for issue #39514 BUG: Reading csv files with numbers with multiple leading zeros losses a lot of precision Feb 1, 2021
@simonjayhawkins simonjayhawkins changed the title BUG: Reading csv files with numbers with multiple leading zeros losses a lot of precision REGR: Reading csv files with numbers with multiple leading zeros losses a lot of precision Feb 1, 2021
@simonjayhawkins simonjayhawkins added the IO CSV read_csv, to_csv label Feb 1, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.2 milestone Feb 1, 2021
jreback
jreback requested changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add the test from the OP. pls run the perf asv's for csv reading to see if this has limited effecct.

@jreback jreback removed this from the 1.2.2 milestone Feb 1, 2021
@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

@CalebBell if you can merge master and update

@CalebBell
Copy link
Author

Hi Jeff,
My apologies, but this PR seems to break other aspects of CSV parsing. I only proposed this as a PR for the CI, but it failed. I was able to quickly find the code point where the issue is, but fixing this the right way will take more work than I can put in right now.

Sincerely,
Caleb

@CalebBell CalebBell closed this Feb 11, 2021
@jreback
Copy link
Contributor

jreback commented Feb 11, 2021

thanks @CalebBell no problem., pls come back on this or other issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Reading csv files with numbers with multiple leading zeros losses a lot of precision
3 participants
@CalebBell @jreback @simonjayhawkins