-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Styler builtins: highlight_between
#39821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b682778
to
6c73f62
Compare
I like this, esp the smile, have to have it. |
# Conflicts: # pandas/tests/io/formats/test_style.py
highlight_range
and highlight_quantile
highlight_range
and highlight_quantile
# Conflicts: # pandas/tests/io/formats/style/test_style.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
# Conflicts: # pandas/tests/io/formats/style/test_highlight.py
# Conflicts: # pandas/io/formats/style.py
can you merge master |
@jreback ping on merge and green |
thanks @attack68 very nice. can you make sure that the notebook is up to date after last few things merged. |
yes I will do that in coming week. |
tests added / passed
Ensure all linting tests pass, see here for how to run them
whatsnew entry
update docs for existing highlight functions for consistency
add a new
props
argument to existing highlight functions.Will add tests if approved:
Could wrap both methods into one as well, but probably easier api if two?