-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: New boundary inputs #40628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: New boundary inputs #40628
Conversation
hewittk
commented
Mar 25, 2021
•
edited
Loading
edited
- Ensure all linting tests pass, see here for how to run them
- tests added / passed
- closes ENH: consistency of input args for boundaries #40245
- whatsnew entry
… simple print statement
This pull request makes for more consistency and flexibility of the arguments for series.between and the validate_endpoints method of date_timelike.py which is the underlying method of |
Thanks for the pr @hewittk! Looks like some unrelated changes crept in - seeing some |
Thank you for letting me know @mzeitlin11! The pip files should be deleted now, let me know if there are any unrelated additions still there that I haven't noticed. |
Looks good now. I think codecov is failing - if you added new options to parameters, we need to make sure that they're all tested (and a whatsnew note should be added explaining user-facing changes there are here) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hewittk for the PR. I made some comments inline. Some of the changes minght be considered non-controversial, and others we might some input from pandas core devs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hewittk docstring validation failure to be resolved before merge, otherwise lgtm
@hewittk can you merge master and fix the doc-string |
there is a test failure on this build: https://github.com/pandas-dev/pandas/pull/40628/checks?check_run_id=2909716187 |
Thanks @hewittk |
Co-authored-by: Kiley Hewitt <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
@hewittk want to make a PR enforcing this deprecation? |