Skip to content

TYP: fix ignores in core.groupby #40643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

@jreback jreback added Groupby Typing type annotations, mypy/pyright type checking labels Mar 26, 2021
@jreback jreback added this to the 1.3 milestone Mar 26, 2021
@jreback
Copy link
Contributor

jreback commented Mar 26, 2021

cc @rhshadrach

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd merged commit 3a973b6 into pandas-dev:master Mar 26, 2021
@WillAyd
Copy link
Member

WillAyd commented Mar 26, 2021

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-gbops branch March 26, 2021 22:01
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants