CLN: move pytest config to pyproject.toml #40656
Conversation
|
I'm reticent to do this. The everything-in-one-file nature of setup.cfg is really nice improvement over the older proliferation of config files |
Isn't pyproject.toml the "new" everything-in-one file? I would love to be able to use |
|
can we move everything to pyproject.toml? (or is this not supported for some things yet)? |
We can also move |
|
And seems like mypy is going to support pyproject.toml soon python/mypy#10219. |
|
Black doesn't support setup.cfg, flake8 doesn't support pyproject.toml, and the xkcd comic about standards is as relevant as ever 😆 Anyway if the pytest docs advise against setup.cfg for pytest, then this PR seems like a good idea, thanks for doing it |
|
LOL... Let me put it here. |
There was a problem hiding this comment.
Looks good to me.
For anyone wondering where -s has gone, the pytest docs say:
-s shortcut for --capture=no.
|
this looks like a net improvement to me, sure we can't move everything yet, but newer versions you can (e.g. isort) |
|
as long as we have someone who is competent with toml to maintain this file, no objection here |
|
hmm somehow a conflict, can you merge master |
|
Thanks @fangchenli ! |
|
@fangchenli running the tests locally, test-data.xml is generated and is an untracked file. probably need to add to git ignore to clean up. |
* CLN: move pytest config to pyproject.toml * fix typo * fix space * fix space * move more opts to config file * move more opts to config file * change min version * add comment back * resolve conflict * unpin pytest version * resolve conflict
* CLN: move pytest config to pyproject.toml * fix typo * fix space * fix space * move more opts to config file * move more opts to config file * change min version * add comment back * resolve conflict * unpin pytest version * resolve conflict
According to https://docs.pytest.org/en/stable/customize.html, using
setup.cfgas pytest config file is not recommended. So moved everything topyproject.toml