[ArrowStringArray] TST: more parameterised testing - part 4 #40963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Testing
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
Apr 21, 2021
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still outstanding:
test_astype_stringinpandas/tests/extension/base/casting.pyrequires separate PR with fixtest_convert_dtypesinpandas/tests/frame/methods/test_convert_dtypes.pyrequires discussion #40747 (comment)... probably need to include in (or follow on to #39908) to at least use the global defaulttest_to_html_formattersinpandas/tests/io/formats/test_to_html.pyparamaterisation where pd.StringArray is used directly... could potentially combine with #40962 and expose ArrowStringArray publicly
the changes here to
test_repeat_with_nullneed a separate PR to fix so could be excluded here.