REF: make Grouping less stateful #41529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
May 18, 2021
pandas/core/groupby/grouper.py
Outdated
| cat = self.grouper | ||
| return cat.codes | ||
| if self._codes is not None: | ||
| # set in __init__ |
There was a problem hiding this comment.
Hmm the comment here is a little confusing. So this is set in init but subsequently set to None?
There was a problem hiding this comment.
self._codes is set in __init__, usually to None, but in one case to an ndarray, in which case we use that. I'll flesh out the comment
|
sure, not sure if need to rebase as merged a couple of other refactors but prob can't hurt |
|
rebased + green |
4 tasks
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of _make_codes, which sets two state variables, in favor of a cache_readonly _codes_and_uniques