DEPR: datetimelike inference with strings #41731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
API - Consistency
jreback
requested changes
May 31, 2021
| @@ -197,7 +197,8 @@ def test_to_timedelta_on_missing_values(self): | |||
| ) | |||
| tm.assert_series_equal(actual, expected) | |||
|
|
|||
| actual = to_timedelta(Series(["00:00:01", pd.NaT])) | |||
| with tm.assert_produces_warning(FutureWarning, match="Inferring timedelta64"): | |||
There was a problem hiding this comment.
can you have some of the tests also assert NO warning if the data is not wrapped in a Series, e.g. just passed to to_timedelta or to_datetime for example should not warn and have the same result as the below.
There was a problem hiding this comment.
might be worth doing for some calls to to_datetime as well (followon ok)
jreback
approved these changes
Jun 1, 2021
TLouf
pushed a commit
to TLouf/pandas
that referenced
this pull request
Jun 1, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this difference in behavior is one of the biggest things left keeping us from sharing more between Index/Series constructors.