REGR: groupby with as_index=False on an empty frame #42254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Groupby
Regression
| @@ -1676,7 +1676,8 @@ def _wrap_transformed_output( | |||
|
|
|||
| def _wrap_agged_manager(self, mgr: Manager2D) -> DataFrame: | |||
| if not self.as_index: | |||
| index = Index(range(mgr.shape[1])) | |||
| rows = mgr.shape[1] if mgr.shape[0] > 0 else 0 | |||
There was a problem hiding this comment.
comment here about why, pointing back to the issue/pr?
There was a problem hiding this comment.
we should strive to move this code inside internal (separate PR for sure)
|
This looks right to me, but merits another pair of eyeballs |
|
this looks good, thanks @rhshadrach |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 28, 2021
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jun 28, 2021
…me (#42280) Co-authored-by: Richard Shadrach <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No whatsnew because this was introduced in 1.3