Skip to content

ENH: Styler.format_index split PR base components #43552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Sep 13, 2021

Splits #43101 to debug failing tests

All this PR does is add a method and fix failing tests because of a minor change to jinja2 templates.

@attack68 attack68 changed the title ENH: Styler.format_index split PR base componenets ENH: Styler.format_index split PR base components Sep 13, 2021
@attack68
Copy link
Contributor Author

This PR suffers the same undiagnosable fault as the mentioned PR..
If anyone fancies having a crack at solving the mysterious failure, please shout out.

@attack68 attack68 force-pushed the styler_format_index_2 branch from 4792ad3 to 2b91410 Compare September 13, 2021 20:50
@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

try renaming this to format_index2 as a test and see if it works

@attack68
Copy link
Contributor Author

try renaming this to format_index2 as a test and see if it works

so that worked? whats the scoop?

@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

try renaming this to format_index2 as a test and see if it works

so that worked? whats the scoop?

wow. so was thinking that .format_index shadows something, but we don't have a method by that name so that's obviously bunk, but maybe we somehow autogenerate something.

@attack68
Copy link
Contributor Author

try renaming this to format_index2 as a test and see if it works

so that worked? whats the scoop?

wow. so was thinking that .format_index shadows something, but we don't have a method by that name so that's obviously bunk, but maybe we somehow autogenerate something.

so you wanna keep the method named like this or something else. i've not faced issue like this before so bit clueless.

@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

must be some sphinx thing

ideally let's keep format_index though could call format_axis

@attack68
Copy link
Contributor Author

OK well this PR now uses format_axis and the original PR still has format_index, which I prefer since it complements apply_index and applymap_index, downside being it breaks the CI and I can't fix it! So you can choose either! (I'll fix up the tests and add the doc examples if you go with this one)

@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

yeah might try to google this
i suspect we can set some sphinx option in conf.py to avoid this

@attack68 attack68 closed this Sep 17, 2021
@attack68 attack68 deleted the styler_format_index_2 branch September 20, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants