DOC: Added sentence to show that unmatched values return -1. #43738
Conversation
|
Hello @DhruvBShetty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-11-01 12:05:03 UTC |
DhruvBShetty
changed the title
pandas/core/indexes/base.py
Outdated
| @@ -3484,6 +3484,9 @@ def get_loc(self, key, method=None, tolerance=None): | |||
| indexer should be then used as an input to ndarray.take to align the | |||
| current data to the new index. | |||
|
|
|||
| Returns -1 for unmatched values, for further explanation see the example | |||
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
Hi @DhruvBShetty can you address the comment please |
Interested in finishing this. |
There was a problem hiding this comment.
please check the pandas docstring guide for how to write the "notes" section
There was a problem hiding this comment.
Can you run the validating docstrings script for this function?
Done, It's the first error After which it's this Left a line between %(raises_section)s and notes accidentally. |
|
Thanks @DhruvBShetty |
In [1]: python make.py --single pandas.Index.get_indexer
Out [1]:
In [2]: pre-commit run --files pandas/core/indexes/base.py
Out [2] :