Skip to content

[ENH] MultiIndex: astype dict #43852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[ENH] MultiIndex: astype dict #43852

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2021

astype multiindex with dict-like of names/int names index with pandas dtype

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

astype multiindex with dict-like of names/int names index with pandas dtype
@pep8speaks
Copy link

pep8speaks commented Oct 2, 2021

Hello @NickFillot! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 5557:1: W293 blank line contains whitespace
Line 5560:1: W293 blank line contains whitespace
Line 5568:1: W293 blank line contains whitespace
Line 5570:1: W293 blank line contains whitespace

Line 3682:1: W293 blank line contains whitespace
Line 3701:1: W293 blank line contains whitespace

Comment last updated at 2021-10-02 14:25:34 UTC

@debnathshoham
Copy link
Member

Thanks for PR @NickFillot!
Is there a particular issue you're working on?

@ghost
Copy link
Author

ghost commented Oct 2, 2021

Hello,

I am trying to fix index typing, on DataFrame.set_index method it doesn't recover the old dtypes

Br
Nicolas

NickFillot added 3 commits October 2, 2021 15:47
inplace new types
Fixing set_indexing data typing
if castable, do, other skip
@attack68
Copy link
Contributor

attack68 commented Oct 2, 2021

Hi @NickFillot, what @debnathshoham means is: is there a pandas issue number that you are working on. Has this problem been discussed?

@ghost
Copy link
Author

ghost commented Oct 3, 2021

Hello,

After deeper checks, i just saw it was pandas.Int64Dtype() (nullable dtypes), and i had object dtype in index

I think it would be nice to set pandas nullable types as dtype instead of object if possible

My bad, thanks for support

Br
Nicolas

@ghost ghost closed this Oct 3, 2021
@ghost ghost deleted the patch-1 branch October 3, 2021 07:07
@ghost
Copy link
Author

ghost commented Oct 3, 2021

Issue for feature request if possible: Issue

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants