Skip to content

ENH: Solution for issue #39859 | Added documentation source link to each page #44783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ADing4818
Copy link

  • closes DOC: add button to edit on GitHub #39859
  • Manual tests were done on a local machine to make sure that the URL splicing was correct and the source docs link was tested in a docker container.
  • whatsnew entry

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please show an example (as screenshot for example)

@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I apologize for the late response. Finals week and everything at the end of the semester was kind of crazy.

Attached below are some screenshots of what I am looking for:

For the 1st screenshot:

ENH Code

This is a code snippet (same as the PR except for line 39) that demonstrates what I am trying to do.

For the 2nd screenshot:

Screen Shot 2021-12-14 at 2 39 10 PM

A UI showing the result would be on each documentation page.

I have tested this locally and the URL splicing works well - I would love to continue working on this feature until hopefully, it gets accepted. Thank you and I look forward to your response.

@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I apologize for the late response. Finals week and everything at the end of the semester was kind of crazy.

Attached below are some screenshots of what I am looking for:

For the 1st screenshot:

ENH Code

This is a code snippet (same as the PR except for line 39) that demonstrates what I am trying to do.

For the 2nd screenshot:

Screen Shot 2021-12-14 at 2 39 10 PM

A UI showing the result would be on each documentation page.

I have tested this locally and the URL splicing works well - I would love to continue working on this feature until hopefully, it gets accepted. Thank you and I look forward to your response.

Also, I wanted to briefly explain my thought process:

I have decided to place the source link, named "Source Documentation" on the sidebar of each documentation page in the sidebar template file.

To make sure that the proper URL is accessed, I broke down the URL into three parts:

  1. Base URL (line 39 in code screenshot above) (Ex: https://github.com/pandas-dev/pandas/blob/master/doc/source/)
  2. Path of file: (line 22 in code screenshot above) (Ex: getting_started/tutorials)
  3. replacing ".html" with ".rst": (line 23 in code screenshot above) (Ex: .rst)

Full URL: https://github.com/pandas-dev/pandas/blob/master/doc/source/getting_started/tutorials.rst

This way, we can ensure that we always access the proper .rst file each time the link is clicked on a given documentation page.

@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I apologize for the late response. Finals week and everything at the end of the semester was kind of crazy.
Attached below are some screenshots of what I am looking for:
For the 1st screenshot:
ENH Code
This is a code snippet (same as the PR except for line 39) that demonstrates what I am trying to do.
For the 2nd screenshot:
Screen Shot 2021-12-14 at 2 39 10 PM
A UI showing the result would be on each documentation page.
I have tested this locally and the URL splicing works well - I would love to continue working on this feature until hopefully, it gets accepted. Thank you and I look forward to your response.

Also, I wanted to briefly explain my thought process:

I have decided to place the source link, named "Source Documentation" on the sidebar of each documentation page in the sidebar template file.

To make sure that the proper URL is accessed, I broke down the URL into three parts:

  1. Base URL (line 39 in code screenshot above) (Ex: https://github.com/pandas-dev/pandas/blob/master/doc/source/)
  2. Path of file: (line 22 in code screenshot above) (Ex: getting_started/tutorials)
  3. replacing ".html" with ".rst": (line 23 in code screenshot above) (Ex: .rst)

Full URL: https://github.com/pandas-dev/pandas/blob/master/doc/source/getting_started/tutorials.rst

This way, we can ensure that we always access the proper .rst file each time the link is clicked on a given documentation page.

Hi @phofl I was wondering if you had seen my recent comments? Thank you for your time and help.

@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I apologize for the late response. Finals week and everything at the end of the semester was kind of crazy.
Attached below are some screenshots of what I am looking for:
For the 1st screenshot:
ENH Code
This is a code snippet (same as the PR except for line 39) that demonstrates what I am trying to do.
For the 2nd screenshot:
Screen Shot 2021-12-14 at 2 39 10 PM
A UI showing the result would be on each documentation page.
I have tested this locally and the URL splicing works well - I would love to continue working on this feature until hopefully, it gets accepted. Thank you and I look forward to your response.

Also, I wanted to briefly explain my thought process:
I have decided to place the source link, named "Source Documentation" on the sidebar of each documentation page in the sidebar template file.
To make sure that the proper URL is accessed, I broke down the URL into three parts:

  1. Base URL (line 39 in code screenshot above) (Ex: https://github.com/pandas-dev/pandas/blob/master/doc/source/)
  2. Path of file: (line 22 in code screenshot above) (Ex: getting_started/tutorials)
  3. replacing ".html" with ".rst": (line 23 in code screenshot above) (Ex: .rst)

Full URL: https://github.com/pandas-dev/pandas/blob/master/doc/source/getting_started/tutorials.rst
This way, we can ensure that we always access the proper .rst file each time the link is clicked on a given documentation page.

Hi @phofl I was wondering if you had seen my recent comments? Thank you for your time and help.

Hello @phofl , I was wondering if you had seen my recent comments? Thank you.

@jreback jreback added the Docs label Jan 3, 2022
@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I apologize for the late response. Finals week and everything at the end of the semester was kind of crazy.
Attached below are some screenshots of what I am looking for:
For the 1st screenshot:
ENH Code
This is a code snippet (same as the PR except for line 39) that demonstrates what I am trying to do.
For the 2nd screenshot:
Screen Shot 2021-12-14 at 2 39 10 PM
A UI showing the result would be on each documentation page.
I have tested this locally and the URL splicing works well - I would love to continue working on this feature until hopefully, it gets accepted. Thank you and I look forward to your response.

Also, I wanted to briefly explain my thought process:
I have decided to place the source link, named "Source Documentation" on the sidebar of each documentation page in the sidebar template file.
To make sure that the proper URL is accessed, I broke down the URL into three parts:

  1. Base URL (line 39 in code screenshot above) (Ex: https://github.com/pandas-dev/pandas/blob/master/doc/source/)
  2. Path of file: (line 22 in code screenshot above) (Ex: getting_started/tutorials)
  3. replacing ".html" with ".rst": (line 23 in code screenshot above) (Ex: .rst)

Full URL: https://github.com/pandas-dev/pandas/blob/master/doc/source/getting_started/tutorials.rst
This way, we can ensure that we always access the proper .rst file each time the link is clicked on a given documentation page.

Hi @phofl I was wondering if you had seen my recent comments? Thank you for your time and help.

Hello @phofl , I was wondering if you had seen my recent comments? Thank you.

Hello @jreback, I was wondering if you could take a look at this chain of comments? I have been waiting for an update on my PR and I would appreciate it if it was reviewed. Thank you.

@ADing4818
Copy link
Author

Could you please show an example (as screenshot for example)

Hello, I was wondering if you saw my previous chain of replies? I wasn't sure if they were being sent properly, but I have sent quite a few comments on this thread regarding your question. Thank you; I want to help resolve this issue.

@MarcoGorelli
Copy link
Member

Hi @ADing4818 - does the link always link to https://github.com/pandas-dev/pandas/tree/master/doc/source/ ? Reading the issue, I think the suggestion was that for each page, the link would go to where in the docs that page was is generated

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@MarcoGorelli
Copy link
Member

Closing for now, let us know if you're still interested in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: add button to edit on GitHub
4 participants