Fix issue #4496: tslib.tz_convert(vals, tz1, tz2) may raise an IndexErro...

[stenri]

Bug-fix for Issue #4496 Bug: tslib.tz_convert(vals, tz1, tz2) may raise an IndexError exception.

[cpcloud]

couple of things, please do the following

• add a test
• hook up travis CI
• add documentation to doc/release.rst, preferentially move the docstring in your test to release notes, but not necessary. if you just want to add a blurb that's fine too.

[cpcloud]

You should rewrite this according to what the hour should be here, don't catch every exception: that could hide another bug.

[stenri]

Thanks! Fixed.

Should I create a new Pull request, or just wait while this one is approved?

[stenri]

• hook up travis CI // done;
• add documentation to doc/release.rst // done (not sure whether such a long bug description is appropriate in release.rst);
• "You should rewrite this according to what the hour should be here, don't catch every exception: that could hide another bug." // That's reasonable. Thanks! Fixed.

[jreback]

@stenri can you rebase and hook up travis?

[stenri]

Surely. I rebased tslib_tz_convert_trans_pos_plus_1__bugfix against upstream/master (and combined all my commits into a one commit).

[jreback]

can you just make this a one-liner here? (and put the explanation with the test, though could be a bit shorter)...thanks

[stenri]

Well.. ok. Though Phillip Cloud asked me to do something that looks exact the opposite (initially my detailed explanation was located within the test doc string):

"add documentation to doc/release.rst, preferentially move the docstring in your test to release notes, but not necessary. if you just want to add a blurb that's fine too."

Anyway, I'll try to make my explanation shorter, and put a one-liner in release.rst.

[jreback]

sorry for the confusion. The idea is that release notes is a pretty short explanation, a doc-string is user visibile should shouldn't be that crazy. Docs can be full explanation. But, in this case its actually a bug fix reference (that won't be there after), so can put in the test suite.

[stenri]

Yeah, I see. I removed detailed explanation from release.rst. Now both release.rst and doc string in unit-test reference Issue #4496, where I wrote the detailed bug description. So interested person can look there for details.

[jreback]

@stenri can you squash into 1 commit? then will merge

[stenri]

Excellent! Done.

[jreback]

thanks!