-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: Pin setuptools for python dev #44989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
should this Line 109 in d228a78
also be pinned? |
Yep, thx |
568c0c3
to
c1e48fd
Compare
Pin additional
ab9fb47
to
bc0d5ed
Compare
Could you leave a |
Done |
merge when ready |
uhh the ArrayManager tests have been going for 4 hours and counting |
hmm 3hrs on second attempt.. Should be allow >=60.0.3 given this release fixes the issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 60.0.3
I think we should be able to avoid pinning this, if the newest version works? |
yes, agreed |
Looks like it does not adress all problems, https://github.com/pandas-dev/pandas/runs/4594019360?check_suite_focus=true Edit: Can reproduce locally |
The experimental data manager issue seems unrelated. I can also see this at https://github.com/pandas-dev/pandas/runs/4594019873?check_suite_focus=true. This has the newest setuptools |
experimental data manager failure is unrelated, see #44994 |
other than ArrayManager is this ready? |
Yes |
ok and the AM tests broke on the json changes? |
actually can we just unpin this? e.g. if >=60.0.3 its working? |
60.0.3 does not work unfortunately. There are still problems. Posted some more info on the issue. |
Yes AM case was from the json change |
cool thanks @phofl ok if you don't mind disabling the failing tests in AM build for the json (and create an issue about it) to get the CI back to green :-> |
Lets see if this works
pandas.show_versions()
#44980