TST: Add tests string series min max #45505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In line with pandas-dev#31746
mroeschke
reviewed
Jan 20, 2022
| def test_reductions_series_strings(): | ||
| # GH#31746 | ||
| ser = Series(["a", "b"], dtype="string") | ||
| assert ser.max() == "b" |
There was a problem hiding this comment.
Could you use pytest.mark.parameterize over min/max and the expected result?
mroeschke
added
the
Testing
mroeschke
reviewed
Jan 22, 2022
| list_str = ["a", "b"] | ||
| ser = Series(list_str, dtype="string") | ||
| res_operation_serie = getattr(ser, operation)() | ||
| func_builtin_python = __builtins__[operation] |
There was a problem hiding this comment.
Hmm instead of this could you hardcore the expected (a or b) with the parameterize as well?
mroeschke
approved these changes
Jan 22, 2022
|
thanks @NumberPiOso |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for max and min aggregation at string series
In line with #31746