Skip to content

TST: Nan must not be converted to string using .loc #45695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2022
Merged

TST: Nan must not be converted to string using .loc #45695

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69ae73a
TST: Nan must not be converted to string
NumberPiOso Jan 29, 2022
2b9442e
Merge branch 'main' into not-change-nan-loc
NumberPiOso Jan 31, 2022
3a8120d
TST: Add test specific to the issue #28403
NumberPiOso Jan 31, 2022
fe9b645
TST: Parametrize multiple inputs change nan loc
NumberPiOso Feb 2, 2022
afe640c
Merge remote-tracking branch 'upstream/main' into not-change-nan-loc
NumberPiOso Feb 2, 2022
f481170
Merge remote-tracking branch 'upstream/main' into not-change-nan-loc
NumberPiOso Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@
from pandas.tests.indexing.common import Base


def test_not_change_nan_loc():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a separate test function for the df = pd.DataFrame({'A': [np.nan, np.nan, 'b']}) case in the issue as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use pytest.mark.parameterize to turn this into 1 test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

# GH 28403
df = DataFrame({"A": [np.nan, "b"]})
df["A"].loc[[0, 1]] = ["a", np.nan]
expected = DataFrame({"A": [False, True]})
tm.assert_frame_equal(df.isna(), expected)
tm.assert_frame_equal(df.notna(), ~expected)


class TestLoc(Base):
def test_loc_getitem_int(self):

Expand Down