TST: Disable testing that hangs Azure CI #45702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
| @@ -266,7 +266,8 @@ def file_leak_context(): | |||
| ContextManager analogue to check_file_leaks. | |||
| """ | |||
| psutil = safe_import("psutil") | |||
| if not psutil: | |||
| if not psutil or is_platform_windows(): | |||
| # Checking for file leaks can hang on Windows CI | |||
There was a problem hiding this comment.
is there a reference for this claim?
There was a problem hiding this comment.
Just anecdotally while investigating #45478.
I noticed disabling the analog check in the excel tests would no longer hang the build around the excel files
mroeschke
changed the title
|
@mroeschke backport? |
Sure might be helpful for the 1.4.x branch as well. |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 30, 2022
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jan 30, 2022
Co-authored-by: Matthew Roeschke <[email protected]>
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #45478
This PR doesn't necessarily guarantee that we won't see random Azure timeouts, but based on working on #45478, these were tests that noticeably caused the CI to hang