Skip to content

REF: simplify factorize, fix factorize_array return type #46214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jreback jreback added the Refactor Internal refactoring of code label Mar 3, 2022
@jreback jreback added this to the 1.5 milestone Mar 3, 2022
@jreback
Copy link
Contributor

jreback commented Mar 3, 2022

looks fine, assuming perf is neutral

@jbrockmendel
Copy link
Member Author

assuming perf is neutral

correct

@jreback jreback merged commit 4985b89 into pandas-dev:main Mar 3, 2022
@jbrockmendel jbrockmendel deleted the ref-vff-2 branch March 3, 2022 20:33
@twoertwein twoertwein mentioned this pull request Mar 5, 2022
3 tasks
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants