Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we are calling
asv
in the CI is too complex for no reason. Removing the next unnecessary things:asv check
not worth calling, since just imports the benchmarks which will be later imported anyway when callingasv run
remote
to git doesn't have any effect I think, since we don't specify the commit, and we should be running benchmarks for what's been checked outasv machine
is not useful, since we won't save the results, or compare them with other runsasv dev
just avoids creating environments, but we can speed up things a bit by just running each benchmark once, and not save the results, which are not used anywayI'm going to see how to remove the hacky grep and just leave the asv call, but I think this needs a new asv release.