BUG: Coerce to native types to_dict list and index (#46751) #46752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerThomas
changed the title
|
@rhshadrach PR for fix |
3 tasks
rhshadrach
requested changes
Apr 19, 2022
doc/source/whatsnew/v1.5.0.rst
Outdated
| @@ -500,6 +500,7 @@ Conversion | |||
| - Bug in :func:`array` with ``FloatingDtype`` and values containing float-castable strings incorrectly raising (:issue:`45424`) | |||
| - Bug when comparing string and datetime64ns objects causing ``OverflowError`` exception. (:issue:`45506`) | |||
| - Bug in metaclass of generic abstract dtypes causing :meth:`DataFrame.apply` and :meth:`Series.apply` to raise for the built-in function ``type`` (:issue:`46684`) | |||
| - Bug in :meth:`DataFrame.to_dict` for ``orient=="list"`` or ``orient=="index"`` was not returning native types. (:issue:`46751`) | |||
There was a problem hiding this comment.
nit: specify as the user would when calling the method; e.g. orient="list". Also no period before the issue #.
There was a problem hiding this comment.
@rhshadrach done
rhshadrach
added
IO Data
|
@rhshadrach looks like there are 2 tests failing that don't seem in any way related to my code, how should I proceed? |
|
It's actually just one; the |
|
Thanks @RogerThomas! |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.