DataFrame.replace with dict doesn't work when value=None #46930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @stanleycai95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-05-02 22:49:26 UTC |
mroeschke
approved these changes
May 3, 2022
|
Thanks @stanleycai95 |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…46930) * _map_values for Series, na_action must be None or "ignore" * Updating docstring for na_action in Series * Revert to old docstring * Use tuple instead of list * Revert to previous commit * Add test for map with invalid na_action argument * Conforming to pep style * Series.map raises if arg is dict but na_action not None or ignore * Update msg * Update f-string * Use pytest.mark.parametrize * Update variable names * Adding backticks * Removing extraneous comment * value should not be given * Value param should not be specified * Remove trailing whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.