BUG: #47350 if else added to add NaT for missing time values

[hamedgibago]

If else added to add NaT rows for missing time values.

[jreback]

not really sure what you are trying to fix. please add a relevant test that fails w/o a change.

[hamedgibago]

not really sure what you are trying to fix. please add a relevant test that fails w/o a change.

Hi, I tried to fix bug #47350. Would you explain more about relevant test that fails w/o a change. I checked the code to return relevant results but some check failed during merge.

[mroeschke]

Please review https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#contributing-to-the-code-base for instructions on how to submit a pull request so that the team understands the changes

[hamedgibago]

Please review https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#contributing-to-the-code-base for instructions on how to submit a pull request so that the team understands the changes

I checked most of the rules in the link. I don't know why most of the Ubuntu, windows and macos get error? Should I compile with any special parameters? Any idea @mroeschke @jreback

[mroeschke]

From the logs, it appears your code change broke existing unit tests

https://github.com/pandas-dev/pandas/runs/7309922086?check_suite_focus=true

[hamedgibago]

@mroeschke @jreback 32 Bit Linux / pytest (pull_request) action raise error for test: FAILED pandas/tests/groupby/test_apply.py::test_group_apply_once_per_group[GH2936]. The error in 'test_group_apply_once_per_group' is that AttributeError: 'DataFrame' object has no attribute 'name'. What should I do with this test? I think dataframe.groupby name property belongs to old versions. This error in this test, prevents CI/CD tests to commit.

[mroeschke]

Ideally all tests should still be passing even when the code fix is made.

[hamedgibago]

@mroeschke Irrelevant codes reverted.

[mroeschke]

Appears you will need to merge in the main branch too.

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

[hamedgibago]

Thank you, I would like to continue working on this bug. I was busy recently, but now really this bug is food for thought for me. I want to start working on it again.

[hamedgibago]

Thank you for reopening.

[mroeschke]

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.