BUG: fix SparseArray.unique IndexError and _first_fill_value_loc algo #47810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GYHHAHA
commented
Jul 21, 2022
mzeitlin11
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Thanks @GYHHAHA! LGTM, can you please add a small note in the 1.5 whatsnew about this fix?
|
Since 1.4.3 and main behave differently, I change the issue title according to the 1.4.3 behavior since it's more closer to the users. In whatsnew, since error on main will not be visible to users, I choose to give the bug description from 1.4.3. |
mroeschke
approved these changes
Jul 22, 2022
|
Thanks @GYHHAHA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Only on master, whatsnew omitted. Please review #47779 after this merged. Remind that
pd.unique/SparseArrayandnp.uniqueis not the same. The former one will keep the original order (which is from pd.core.algorithms.unique) and numpy unique will sort the result. cc @mzeitlin11