Skip to content

DOC: Add mention that mangle_dupe_cols is deprecated in user guide #48182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

DOC: Add mention that mangle_dupe_cols is deprecated in user guide #48182

merged 2 commits into from
Aug 23, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 20, 2022

@phofl phofl added Docs Deprecate Functionality to remove in pandas labels Aug 20, 2022
@phofl phofl added this to the 1.5 milestone Aug 20, 2022
datapythonista
datapythonista reviewed Aug 21, 2022
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl, good catch, I didn't know or expect to have about mangle_dupe_cols in the user guide, as this was never implemented. I propose one change, but looks good.

doc/source/user_guide/io.rst
.. deprecated:: 1.5.0
``mangle_dupe_cols`` was never implemented, and a new argument where the
renaming pattern can be specified will be added instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally update the section to just show that we rename columns, and remove all the references to mangle_dupe_cols, which never worked anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Removed the example with False

@phofl
Copy link
Member Author

phofl commented Aug 22, 2022

@datapythonista ready to merge?

@datapythonista datapythonista merged commit eb226bd into pandas-dev:main Aug 23, 2022
@phofl phofl deleted the doc_mangle_dupe_cols_deprecation branch August 23, 2022 07:30
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
DOC: Add mention that mangle_dupe_cols is deprecated in user guide (p…
d4da966 
…andas-dev#48182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Docs
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @datapythonista @mroeschke