REGR: AttributeError: 'bool' object has no attribute 'to_numpy' in "mask_missing" #48313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Missing-data
This was referenced Aug 30, 2022
Closed
| if not isinstance(new_mask, np.ndarray): | ||
| # GH#47101 we may get a scalar new_mask if elementwise comparison fails | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", FutureWarning) |
Member
There was a problem hiding this comment.
is there a condition under which we can remove this check?
Member
Author
There was a problem hiding this comment.
I assume when the numpy behaviour changes and a FutureWarning is no longer given.
Member
Author
There was a problem hiding this comment.
Note: the warning was not being suppressed in 1.3.5 so not strictly needed for the regression fix.
Member
Author
|
closing so can start release tomorrow |
tigerhawkvok
added a commit
to tigerhawkvok/pandas
that referenced
this pull request
Aug 12, 2024
Bisecting two years ago ( pandas-dev#47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then. PR pandas-dev#48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.
tigerhawkvok
added a commit
to tigerhawkvok/pandas
that referenced
this pull request
Sep 9, 2024
* Fix issue pandas-dev#47101 Bisecting two years ago ( pandas-dev#47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then. PR pandas-dev#48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted. * Add a test as per PR guidelines * Fix typo * Resolve inconsistent namespace as per PR test https://results.pre-commit.ci/run/github/858127/1723498369.6V12SWx7T-WpLZDAXXkz0Q This web UI commit will still fail, as the E501 line-too-long check will fail until the next commit * Resolve E501 linting errors https://results.pre-commit.ci/run/github/858127/1723498369.6V12SWx7T-WpLZDAXXkz0Q * Fix test TypeErrors np.equal([1,2,3], "") fails * Quote style for Ruff * typing and remove code backtick possibly incorrectly triggering ruff formatter * mpy supression for caught error * trailing space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.