PERF: Add var to masked arrays #48379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
NA - MaskedArrays
# Conflicts: # pandas/core/array_algos/masked_reductions.py # pandas/core/arrays/masked.py # pandas/tests/reductions/test_reductions.py
mroeschke
reviewed
Sep 12, 2022
mroeschke
reviewed
Sep 12, 2022
| @@ -787,6 +787,15 @@ def test_mean_masked_overflow(self): | |||
| assert result_masked - result_numpy == 0 | |||
| assert result_masked == 1e17 | |||
|
|
|||
| def test_var_masked_array(self): | |||
There was a problem hiding this comment.
Could you parameterize over ddof=[0, 1]?
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Sep 13, 2022
# Conflicts: # doc/source/whatsnew/v1.6.0.rst
|
This patch may have induced a potential regression. Please check the links below. If any ASVs are parameterized, the combinations of parameters that a regression has been detected appear as subbullets. This is a partially automated message.
|
|
Here is a more direct link (still need to workout how to incorporate parameterizations in the link): |
|
Hm guess boolean is special casy here. We could cast the array to float, this would get most of the regression back, but not sure if this is worth it |
|
Taking the variance of Booleans seems pretty rare to me, but at the same time, the solution sounds very easy. I'm thinking to at least open a tracking issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.