Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Sep 10, 2022

Will investigate in a follow up, if we can send this through the regular groupby ops code paths

@phofl phofl added Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Sep 10, 2022
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added this to the 1.6 milestone Sep 12, 2022
@mroeschke mroeschke merged commit b44db5c into pandas-dev:main Sep 12, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the mask_groupby_qantile branch September 12, 2022 18:03
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* ENH: Support mask properly in GroupBy.quantile

* Fix mypy

* Fix typo

* Add type hint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants