change test such that it passes in headless mode (instead of xpass) #48520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and xpass in non-headless mode (instead of error)
|
Hello @adrienpacifico! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-09-12 22:49:12 UTC |
mroeschke
reviewed
Sep 12, 2022
mroeschke
added
the
Testing
mroeschke
approved these changes
Sep 13, 2022
|
Great! Thanks @adrienpacifico |
|
These are now xpassing for me on mac, py39 |
|
jbrockmendel and it was passing before the PR or was it xpassing? |
correct |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…andas-dev#48520) * change test such that it passes in headless mode (instead of xpass), and xpass in non-headless mode (instead of error) * linting * add single_cpu mark * correct the odorerr of pytest.mark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and xpass in non-headless mode (instead of error).
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.