BUG: to_datetime raising on invalid offsets with errors=coerce and infer_datetime_format #48676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
dont-raise-guessing-format-on-wrong-offset
branch
from
cf5bc0a to
73611e8
Compare
…fer_datetime_format
MarcoGorelli
force-pushed
the
dont-raise-guessing-format-on-wrong-offset
branch
from
73611e8 to
4c00b86
Compare
mroeschke
reviewed
Sep 21, 2022
| # GH 28299 | ||
| ts_strings = ["200622-12-31", "111111-24-11"] | ||
| result = to_datetime(ts_strings, errors="coerce") |
There was a problem hiding this comment.
Curious, do we have a similar test when errors="ignore"?
There was a problem hiding this comment.
good catch! indeed, that errors
There was a problem hiding this comment.
actually it's fine (I may not have rebuilt my c extensions when I left the comment above) - have parametrised over errors in the test now, thanks
added 2 commits
October 5, 2022 15:02
…-format-on-wrong-offset
mroeschke
approved these changes
Oct 5, 2022
|
Thanks @MarcoGorelli |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…fer_datetime_format (pandas-dev#48676) * BUG: to_datetime raising on invalid offsets with errors=coerce and infer_datetime_format * fix invalid type test * test errors=ignore as well Co-authored-by: MarcoGorelli <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.