Unexpected keyword argument

[shalearkane]

This fixed unexpected-keyword-argument warnings from pylint on one file.
The other warnings produced were already expected to be caught in tests.

• xref STYLE fix pylint issues #48855 one of many style checks, still needs work.

[shalearkane]

pre-commit is failing because I am using Optional type annotation with the older syntax Optional[type] as the newer syntax type | None is only supported on Python 3.10+

[MarcoGorelli]

pre-commit is failing because I am using Optional type annotation with the older syntax Optional[type] as the newer syntax type | None is only supported on Python 3.10+

it's supported with from __future__ import annotations, which is at the top of the file

[MarcoGorelli]

Thanks for your PR

I don't think this is the right fix, as these arguments (name, copy, ...) get passed to NumericIndex, rather than to _constructor

[shalearkane]

Yes, I looked into the code. Classes ExtensionIndex, MultiIndex and NumericIndex inherits from the base class Index.

And

• MultiIndex and
• RangeIndex (which inherits from NumericIndex)

is overriding the _constructor method.

So should I include the function arguments in the _constructor method of those classes too?

[shalearkane]

[MarcoGorelli]

wait, this isn't resolved - I think the issue is that pylint can't tell that @cache_readonly makes _constructor act like a property and that it doesn't take arguments

I'll have another look later

[MarcoGorelli]

wait, this isn't resolved - I think the issue is that pylint can't tell that @cache_readonly makes _constructor act like a property and that it doesn't take arguments

I'll have another look later

[MarcoGorelli]

Thanks @shalearkane for your PR

I've had a closer look, and I don't think we should enable this check

cache_readonly acts like a property, but pylint isn't aware of this and so it thinks that the arguments that are passed to whetever function the property returns are being passed to the property itself

mypy already checks this, and the way pandas gets mypy to recognise that cache_readonly is a property is

pandas/pandas/_libs/properties.pyi

Line 16 in 7440fe2

cache_readonly = property

So, I'll add this to the list of checks we probably can't turn off

Closing for now then