Skip to content

made changes to resolve unsupported-assignment-operation from #48855 #48982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

made changes to resolve unsupported-assignment-operation from #48855 #48982

wants to merge 1 commit into from

Conversation

jetale
Copy link

@jetale jetale commented Oct 7, 2022

MarcoGorelli
MarcoGorelli suggested changes Oct 7, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for working on this

I'm afraid we can't take these changes though, as pandas does support __setitem__ and that behaviour should be tested - we'll just have to keep this lint check turned off I think

@slackline slackline mentioned this pull request Oct 9, 2022
Closed
@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Oct 14, 2022
@mroeschke
Copy link
Member

Instead, could you just write a comment next to this entry in the pyproject.tomll why this is turned off?

@MarcoGorelli
Copy link
Member

closing this one for now, but thanks for your PR!

The ones we probably can't turn off are listed in #48855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STYLE fix pylint issues
3 participants
@jetale @mroeschke @MarcoGorelli