DOC Replace gitter badge with one for slack #49149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -13,7 +13,7 @@ | |||
| [](https://codecov.io/gh/pandas-dev/pandas) | |||
| [](https://api.securityscorecards.dev/projects/github.com/pandas-dev/pandas) | |||
| [](https://pepy.tech/project/pandas) | |||
| [](https://gitter.im/pydata/pandas) | |||
| [](https://pandas.pydata.org/docs/dev/development/community.html?highlight=slack#community-slack) | |||
There was a problem hiding this comment.
Should slack be Slack with capital S?
There was a problem hiding this comment.
I went with lowercase out of habit/matching most of the other badges.
Shields API does support capitalization here, PR updated.
There was a problem hiding this comment.
I think what was meant was [![slack] ... -> [![Slack] ... in the beginning of the line
There was a problem hiding this comment.
facepalm.gif
Yeah, I need more sleep.
mroeschke
approved these changes
Oct 17, 2022
|
Thanks @roadswitcher |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* Add badge using shields.io * Remove gitter badge. * Update README * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.