Skip to content

DEPR: Enforce default of numeric_only=False in DataFrame methods #49622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 11, 2022
Merged

DEPR: Enforce default of numeric_only=False in DataFrame methods #49622

merged 7 commits into from
Nov 11, 2022

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@rhshadrach rhshadrach added Deprecate Functionality to remove in pandas DataFrame DataFrame data structure Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply labels Nov 10, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Nov 10, 2022
@rhshadrach
Copy link
Member Author

Thanks @jbrockmendel - changed the removal of deprecated to versionchanged and added a line about Series.rank in the whatsnew - that's the only Series method that didn't default to numeric_only=False.

mroeschke
mroeschke approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jbrockmendel merge when ready

@jbrockmendel jbrockmendel merged commit 9dbb7d7 into pandas-dev:main Nov 11, 2022
@jbrockmendel
Copy link
Member

thanks @rhshadrach

@rhshadrach rhshadrach deleted the enforce_numeric_only_default_false branch November 11, 2022 18:30
codamuse pushed a commit to codamuse/pandas that referenced this pull request Nov 12, 2022
@rhshadrach @codamuse
DEPR: Enforce default of numeric_only=False in DataFrame methods (pan…
a38a34f 
…das-dev#49622)

* DEPR: Enforce default of numeric_only=False

* Remove unused functions

* Add versionchanged

* Add Series.rank to whatsnew

* newline in docs
mliu08 pushed a commit to mliu08/pandas that referenced this pull request Nov 27, 2022
@rhshadrach @mliu08
DEPR: Enforce default of numeric_only=False in DataFrame methods (pan…
104e979 
…das-dev#49622)

* DEPR: Enforce default of numeric_only=False

* Remove unused functions

* Add versionchanged

* Add Series.rank to whatsnew

* newline in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
DataFrame DataFrame data structure Deprecate Functionality to remove in pandas Nuisance Columns Identifying/Dropping nuisance columns in reductions, groupby.add, DataFrame.apply
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rhshadrach @jbrockmendel @mroeschke