-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
STYLE: Enable unnecessary list index lookup #49911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STYLE: Enable unnecessary list index lookup #49911
Conversation
Fix one instance of the issue and add messages to suppress several others in test modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this
could you please:
- run the pre-commit checks (see contributing guide for how)
- fetch upstream, and rebase onto it, looks like you have some irrelevant changes in here
@MarcoGorelli , are you talking about the changes to If you'd like, I can change them back. |
ah, that's fine then, thanks for explaining! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @uzzell
Associated with #48855. Enables the Pylint type "R" warning
unnecessary-list-index-lookup
. Also updates the list of intentionally disabled checks.