Skip to content

Conversation

@Hanspagh
Copy link
Contributor

@Hanspagh Hanspagh commented Nov 30, 2022

This PR adds test to address the issue in #49337, which have already been fixed on main

Do you want a entry in the changelog since this is not a fix, just a test to ensure we dont run into this again?
- [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.



@pytest.mark.parametrize("case", [0.5, "xxx"])
@pytest.mark.parametrize(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid changing unrelated lines for style. We use black via precommit to autoformat the code base: https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#pre-commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, ran pre-commit to address

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 30, 2022
@Hanspagh Hanspagh marked this pull request as ready for review December 1, 2022 08:20
@Hanspagh
Copy link
Contributor Author

Hanspagh commented Dec 1, 2022

Failing test seems unrelated to this

@pytest.mark.parametrize(
"b",
[
pd.Categorical(["a", "b"], categories=["b", "a"]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is one of these supposed to have ordered=True like in the original issue? Otherwise both b params are the same

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jan 1, 2023
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jan 3, 2023
@Hanspagh
Copy link
Contributor Author

Hanspagh commented Jan 5, 2023

rebased master and addresses the comment, I dont think the PR sync while it is closed so you cant see the newest commit

@mroeschke
Copy link
Member

For some reason I cannot re-open this pull request. Mind opening up another one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants