Skip to content

DEV: remove geopandas from the environment.yml file #49994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

StefanieSenger
Copy link
Contributor

@StefanieSenger StefanieSenger commented Dec 1, 2022

@MarcoGorelli
Copy link
Member

Thanks for working on this

@mroeschke you'd said you wanted the environment to enable people to run anything - should this single downstream test be removed?

@MarcoGorelli
Copy link
Member

Hi @StefanieSenger - did you close this by accident? I think it looks right, I just wanted to double-check with Matthew whether we should also remove the downstream test or whether this is fine as-is

@StefanieSenger
Copy link
Contributor Author

StefanieSenger commented Dec 1, 2022

@MarcoGorelli I must have, though I didn't realise I did ... I'd like to keep it open. Sorry, was my first ever open source contribution.

@mroeschke
Copy link
Member

Yeah I would be partial to be consistent and remove geopandas everywhere if we also want to remove it from the environment.yml for consistency (CI dependency files, unit tests, any ASVs, any doc reference)

@phofl
Copy link
Member

phofl commented Dec 1, 2022

@StefanieSenger could you remove it from the environment.yml again?

Additionally, you can delete the test test_geopandas in pandas/tests/test_downstream.py to get the ci passing. We can reopen the pr then

@jorisvandenbossche
Copy link
Member

Specifically for geopandas, I think we can indeed remove the test as well, and then the concern of not having all optional test dependencies installed is also gone (geopandas runs its CI with pandas main, so that should catch any potential compatibility issue relative fast as well).

For the more general issue about other dependencies in little usage in environment.yml, I opened #49998
(removing geopandas from environment.yml won't actually remove it from the env, because it is also indirectly a dependency of pandas_gbq, another optional dependency only needed for a very few number of tests)

@jorisvandenbossche
Copy link
Member

@StefanieSenger if you want to reopen the PR, you will first have to "restore" the branch (there should be a button somewhere in the UI)

@StefanieSenger
Copy link
Contributor Author

Thanks for the instructions and the beginner friendly atmosphere. I will do this some time today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants