CI minimum mpl version everywhere #50205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Dec 12, 2022
| @@ -34,7 +34,7 @@ dependencies: | |||
| - gcsfs | |||
| - jinja2 | |||
| - lxml | |||
| - matplotlib | |||
| - matplotlib>=3.6.1 | |||
There was a problem hiding this comment.
I think we should do this for every dependency. cc @mroeschke
There was a problem hiding this comment.
agreed
this seems to be working - we OK to merge this to get CI green again, and then we can make a script to automate that in a separate PR?
There was a problem hiding this comment.
Agreed, and to update our min version script to account for these dependency files
phofl
approved these changes
Dec 12, 2022
|
thx @MarcoGorelli |
|
@MarcoGorelli could you look into 1.5.x? We get failures there as well but will need a different min version probably |
|
🤔 don't know, the minimum version is set to 3.3.2 in that branch, and that's exactly what CI is pulling in. will investigate |
|
@meeseeks-dev backport to 1.5.x |
|
@meeseeksdev backport to 1.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 12, 2022
MarcoGorelli
added a commit
that referenced
this pull request
Dec 13, 2022
#50211) Backport PR #50205: CI minimum mpl version everywhere Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.