Skip to content

ENH: Allow ArrowDtype(pa.string()) to be compatable with str methods #50325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from

Conversation

mroeschke
Copy link
Member

This implementation is somewhat similar but kept separate to the methods in ArrowStringArray because I tailored ArrowExtensionArray to always return ArrowExtensionArray (most obvious in _str_map) as opposed to falling back to pandas masked arrays.

Additionally:

  • any_string_method pytest fixture to pandas/conftest.py so it can be used by extensions/test_arrow.py
  • Removed some imports into pandas/core/strings/__init__.py as it was causing a circular dependency when adding this to ArrowExtensionArray

@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Dec 17, 2022
@mroeschke
Copy link
Member Author

Closing in favor of #51207

@mroeschke mroeschke closed this Feb 7, 2023
@mroeschke mroeschke deleted the enh/arrowdtype_str_methods branch February 7, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant