BUG: astype to pyarrow does not copy np array #50984
Conversation
|
worth adding this to tm.shares_memory? |
|
Raises a NotImplementedError (no arrow support) Will have a look at this in a follow up |
pandas/core/arrays/arrow/array.py
Outdated
| @@ -218,6 +218,9 @@ def _from_sequence(cls, scalars, *, dtype: Dtype | None = None, copy: bool = Fal | |||
| if isinstance(scalars, cls): | |||
| scalars = scalars._data | |||
| elif not isinstance(scalars, (pa.Array, pa.ChunkedArray)): | |||
| if copy and is_array_like(scalars): | |||
| # pa array should not get updated when numpy array is updated | |||
| scalars = scalars.copy() | |||
There was a problem hiding this comment.
Is it worth specifying np.array(scalars, copy=True) manually? There might be an off chance the arraylike doesn't have a copy method?
There was a problem hiding this comment.
This would cast our nullables to object, so not ideal
There was a problem hiding this comment.
Ah gotcha. Would calling copy.copy(...) be safer then?
There was a problem hiding this comment.
We need deepcopy, but this should do the trick
There was a problem hiding this comment.
There might be an off chance the arraylike doesn't have a copy method?
might make more sense to raise than guess if this occurs?
There was a problem hiding this comment.
No preference here, cc @mroeschke
|
Thanks @phofl |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke
This should copy. You can't update the pyarrow array, but the parent array can get updated which propagates to the pyarrow array.