Skip to content

REF: Resampler.groupby -> _timegrouper #51135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2023
Merged

REF: Resampler.groupby -> _timegrouper #51135

merged 1 commit into from
Feb 3, 2023

Conversation

jbrockmendel
Copy link
Member

GroupBy object is very different from a TimeGrouper object. Hopefully this will make this code slightly less confusing (xref #51134 this is a PITA)

@jbrockmendel jbrockmendel changed the title REF: Resample.groupby -> _timegrouper REF: Resampler.groupby -> _timegrouper Feb 3, 2023
@mroeschke mroeschke added Refactor Internal refactoring of code Groupby Resample resample method labels Feb 3, 2023
@mroeschke mroeschke added this to the 2.0 milestone Feb 3, 2023
@mroeschke mroeschke merged commit dc1c97c into pandas-dev:main Feb 3, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-resample-2 branch February 3, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Groupby Refactor Internal refactoring of code Resample resample method
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke