BUG: bug in Index._should_fallback_to_positional #51241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Feb 8, 2023
pandas/core/indexes/base.py
Outdated
| if isinstance(self.dtype, np.dtype) and self.dtype.kind in ["i", "u", "f"]: | ||
| return False | ||
| return not self._holds_integer() | ||
| return not is_numeric_dtype(self.dtype) or is_bool_dtype(self.dtype) |
There was a problem hiding this comment.
does this impact perf? the is_foo_dtype checks are pretty slow
There was a problem hiding this comment.
I looked into using inferred and it is better, 120 ns now, vs 1000 ns in first version.
mroeschke
added
Indexing
mroeschke
approved these changes
Feb 13, 2023
|
Thanks @topper-123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Fixes #51053.