Skip to content

TST: add CoW tests for xs() and get() #51292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #49473

Adding basic tests for xs and get. Those rely on indexing methods under the hood, and thus already work correctly for CoW, but adding some basic tests to have independent coverage.

@jorisvandenbossche jorisvandenbossche added this to the 2.0 milestone Feb 10, 2023
@jorisvandenbossche jorisvandenbossche changed the title TST: add COW tests for xs() and get() TST: add CoW tests for xs() and get() Feb 10, 2023
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, lgtm

@jorisvandenbossche
Copy link
Member Author

Failures are unrelated, so merging

@jorisvandenbossche jorisvandenbossche merged commit 7bdf69f into pandas-dev:main Feb 10, 2023
@jorisvandenbossche jorisvandenbossche deleted the cow-tests-xs-get branch February 10, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants