Skip to content

PERF: use "_name" instead of "name" as Series metadata to avoid validation #51784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorisvandenbossche merged 3 commits into from
Mar 23, 2023
Merged

PERF: use "_name" instead of "name" as Series metadata to avoid validation #51784

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f516f4f
PERF: use _name instead of name as Series metadata to avoid validation
jorisvandenbossche Mar 4, 2023
ce2bedb
add 'name' to internal_names_set
jorisvandenbossche Mar 4, 2023
15fc059
Merge remote-tracking branch 'upstream/main' into perf-finalize-name
jorisvandenbossche Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,8 +346,8 @@ class Series(base.IndexOpsMixin, NDFrame): # type: ignore[misc]
_HANDLED_TYPES = (Index, ExtensionArray, np.ndarray)

_name: Hashable
_metadata: list[str] = ["name"]
_internal_names_set = {"index"} | NDFrame._internal_names_set
_metadata: list[str] = ["_name"]
_internal_names_set = {"index", "name"} | NDFrame._internal_names_set
_accessors = {"dt", "cat", "str", "sparse"}
_hidden_attrs = (
base.IndexOpsMixin._hidden_attrs | NDFrame._hidden_attrs | frozenset([])
Expand Down