STYLE: enable ruff TCH on some file

[luke396]

xref #51740, to fix

"pandas/core/construction.py" = ["TCH"] 
"pandas/core/missing.py" = ["TCH"] 
"pandas/tseries/*" = ["TCH"] 
"pandas/tests/*" = ["TCH"] 
"pandas/plotting/*" = ["TCH"] 

[luke396]

same as #51812

[luke396]

if add TYPE_CHECKING, will cause import error, in pandas/tests/io/json/test_json_table_schema_ext_dtype.py

[MarcoGorelli]

any idea why? would it work to add from __future__ import annotations at the top of this file?

[twoertwein]

Based on the pytest failures, adding a future import to pandas/tests/extension/date/array.py should fix this. (Wasn't there a script to enforce that all files have future imports?)

[luke396]

It seems like there have been a lot of changes to the type annotations, and I can't determine whether they will have a significant impact or not.

Edit: if we add a script to enforce all files have future imports, the type annotation maybe change a lot too.

[luke396]

It seems like there have been a lot of changes to the type annotations, and I can't determine whether they will have a significant impact or not.

Edit: if we add a script to enforce all files have future imports, the type annotation maybe change a lot too.

I searched for some information and found that these type annotation changes might be due to a new annotation feature introduced in a newer version of Python. It seems that this change does not have a significant impact, except for compatibility with older versions of Python.

[MarcoGorelli]

the check excludes test files (though perhaps it should include them?)

pandas/.pre-commit-config.yaml

Lines 402 to 413 in f7f0df1

	- id: future-annotations
	name: import annotations from __future__
	entry: 'from __future__ import annotations'
	language: pygrep
	args: [--negate]
	files: ^pandas/
	types: [python]
	exclude: |
	(?x)
	/(__init__\.py)|(api\.py)|(_version\.py)|(testing\.py)|(conftest\.py)$
	|/tests/
	|/_testing/

[luke396]

the check excludes test files (though perhaps it should include them?)

pandas/.pre-commit-config.yaml

Lines 402 to 413 in f7f0df1

	- id: future-annotations
	name: import annotations from __future__
	entry: 'from __future__ import annotations'
	language: pygrep
	args: [--negate]
	files: ^pandas/
	types: [python]
	exclude: |
	(?x)
	/(__init__\.py)|(api\.py)|(_version\.py)|(testing\.py)|(conftest\.py)$
	|/tests/
	|/_testing/

Sorry for the late reply. If necessary, I can open a pr and manually or automatically add 'from future import annotations'.

[MarcoGorelli]

thanks for your pr, looks like there's some errors https://github.com/pandas-dev/pandas/actions/runs/4362414904/jobs/7627283459

[luke396]

thanks for your pr, looks like there's some errors https://github.com/pandas-dev/pandas/actions/runs/4362414904/jobs/7627283459

This was because of a careless mistake and should be fine now

[MarcoGorelli]

thanks @luke396 ! not many left, we're getting there