CoW: Delay copy when setting Series or Frame with isetitem #52051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/core/frame.py
# Conflicts: # pandas/core/frame.py
phofl
added
Indexing
5 tasks
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
5 tasks
# Conflicts: # pandas/core/frame.py # pandas/tests/copy_view/test_setitem.py
jorisvandenbossche
approved these changes
May 5, 2023
| arraylike, _ = self._sanitize_column(value.iloc[:, i]) | ||
| self._iset_item_mgr(idx, arraylike, inplace=False) | ||
| arraylike, refs = self._sanitize_column( | ||
| value.iloc[:, i], using_cow=using_cow |
There was a problem hiding this comment.
Could we actually call using_copy_on_write() inside _sanitize_column instead of having to pass it everywhere?
There was a problem hiding this comment.
Yes this will be a clean up when all the other PRs are merged
topper-123
pushed a commit
to topper-123/pandas
that referenced
this pull request
May 7, 2023
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.sits on top of #51698